Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix search of username in admin section #23

Closed
wants to merge 1 commit into from
Closed

fix search of username in admin section #23

wants to merge 1 commit into from

Conversation

fermayo
Copy link

@fermayo fermayo commented Oct 29, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6f7cb2f on fermayo:fix-admin into 105ec5c on Bouke:master.

@Bouke
Copy link
Collaborator

Bouke commented Oct 29, 2014

Could you also provide a unit test for your fix? There are already some admin tests in the aptly named AdminTests.

@Bouke Bouke added the bug label Oct 29, 2014
@Bouke Bouke mentioned this pull request Nov 3, 2014
@Gwildor
Copy link

Gwildor commented Nov 4, 2014

Do note that because of custom user models, there might be user models without an username field. I'm not sure what the proper solution for that is. Perhaps search by first_name and last_name. Starting from Django 1.5 you can use the User.USERNAME_FIELD attribute, but that one is not present in Django 1.4.

@Bouke Bouke closed this in a281f3c Nov 4, 2014
@Bouke
Copy link
Collaborator

Bouke commented Nov 4, 2014

I've pushed a commit that should fix this issue, could you have a look? I can make an official bug fix release after I get your confirmations.

@Gwildor
Copy link

Gwildor commented Nov 4, 2014

Can't check this now; I will have a look at this on Thursday.

@Gwildor
Copy link

Gwildor commented Nov 6, 2014

I can confirm that this issue has been fixed. Nice solution, by the way.

@Bouke
Copy link
Collaborator

Bouke commented Nov 11, 2014

Thanks :). I've also pushed a new version (1.1.0) containing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants