Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf_file_names should not have default value #126

Open
3 tasks
rabutler-usbr opened this issue May 23, 2023 · 1 comment
Open
3 tasks

nf_file_names should not have default value #126

rabutler-usbr opened this issue May 23, 2023 · 1 comment

Comments

@rabutler-usbr
Copy link
Contributor

rabutler-usbr commented May 23, 2023

Previously I've been updating the default version = parameter. But doing this means that running nf_file_name() with two different versions of CRSSIO could result in two different sets of file names being created. Seems better to remove the default, and require user to provide it.

This should be a simple change, but the Shiny add in always uses the default version. So, will need to update the Shiny app.

Consider adding 'latest' as a valid argument. Then app and other functions could always use latest, but user would know that's the case.

  • remove default in nf_file_names() and natsalt_file_names()
  • update Shiny app
  • tests
@rabutler-usbr
Copy link
Contributor Author

rabutler-usbr commented May 23, 2023

added message to nf_file_names() that future versions will require specified version, if default value is used.

Using warning was a lot of trouble for all the tests that don't use a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant