Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"JLCPCB Library" shall display a better Description #17

Closed
bvernoux opened this issue Aug 30, 2021 · 3 comments
Closed

"JLCPCB Library" shall display a better Description #17

bvernoux opened this issue Aug 30, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@bvernoux
Copy link
Contributor

bvernoux commented Aug 30, 2021

In "JLCPCB Library" display add the Description from https://github.com/yaqwsx/jlcparts/blob/master/LCSC-API.md (instead of the ones from https://jlcpcb.com/parts) as the one from https://jlcpcb.com/parts is unreadable and not accurate

  • Maybe first step will be to "parse/extract/display" correctly the "LCSC Description" from the csv as it is not displayed correctly today.
  • Example screenshot with issue (°C ... not displayed correctly ...) on Description
    image
    image
@Bouni Bouni added the enhancement New feature or request label Aug 31, 2021
@Bouni
Copy link
Owner

Bouni commented Sep 8, 2021

I fixed "incorrect description" with 0ce0c3d
The encoding of the CSV is gbk rather than iso-8859-1

@Bouni
Copy link
Owner

Bouni commented Sep 8, 2021

As this is kind of the same issue / enhancement as #16 I'll go to work out a solution over there and use it in bth, the main window and the library.

@Bouni Bouni closed this as completed Sep 8, 2021
@bvernoux
Copy link
Contributor Author

I confirm all work fine with Windows10 + KiCad Nightly (r24220)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants