Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to filter on column (for main window "JLCPCB Tools" and "JLCPCB Library") #19

Closed
bvernoux opened this issue Aug 30, 2021 · 3 comments
Labels
enhancement New feature or request maybe later Maybe fix/improve this later

Comments

@bvernoux
Copy link
Contributor

bvernoux commented Aug 30, 2021

Add a way to filter on column (for main window "JLCPCB Tools" and "JLCPCB Library")

  • Just a simple filter (Sort Ascending/Descending) on one column at a time if possible with "natural sort" (like we have in LibreOffice Calc => Menu Data => Sort... => Options => Enable natural sort)
@Bouni Bouni added the enhancement New feature or request label Aug 31, 2021
@Bouni
Copy link
Owner

Bouni commented Sep 16, 2021

wx allow to make columns sortable, which I added with the latest commit. Not sure if it sorts the way you want it to but I'm statisfied 😉
@bvernoux please check if this fit your needs

@bvernoux
Copy link
Contributor Author

I confirm the column sort work fine (even if it does not use "natural sort" which means for example when you have C1 to C9 then C10 the natural sort will sort it like that in your case with standard sort it does C10, C1, C2 ....) which is not very convenient but ok

@Bouni
Copy link
Owner

Bouni commented Sep 17, 2021

I think I could implement a custom sorting function and call it on click to the header.
But to be honest, thats a lot of work for a minor improvement.
Maybe I go for that in the future and leave it as it is for now.
I hope you can live with that 😅

@Bouni Bouni closed this as completed Sep 17, 2021
@Bouni Bouni added the maybe later Maybe fix/improve this later label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe later Maybe fix/improve this later
Projects
None yet
Development

No branches or pull requests

2 participants