Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate without zones refill #303

Closed
radoslav006 opened this issue Apr 15, 2023 · 5 comments · Fixed by #314
Closed

Generate without zones refill #303

radoslav006 opened this issue Apr 15, 2023 · 5 comments · Fixed by #314
Assignees
Labels
bug Something isn't working

Comments

@radoslav006
Copy link

Describe the bug
Tool refills out-of-date zones even if one select to not do that.

To Reproduce
Steps to reproduce the behavior:

  1. Project without refilled zones.
  2. Click "Genereate".
  3. Tool asks "Zones fills are out-of-date. Refill?".
  4. I choose "Continue without refill".
  5. After gerbers inspections it turns out that zones are refilled anyway.

Expected behavior
Zones shall remain unfilled.

KiCad Version

Application: KiCad PCB Editor (64-bit)

Version: (6.0.1), release build

Libraries:
	wxWidgets 3.1.5
	libcurl/7.78.0-DEV Schannel zlib/1.2.11

Platform: Windows 10 (build 19044), 64-bit edition, 64 bit, Little endian, wxMSW

Build Info:
	Date: Jan 15 2022 13:36:27
	wxWidgets: 3.1.5 (wchar_t,wx containers)
	Boost: 1.76.0
	OCC: 7.5.0
	Curl: 7.78.0-DEV
	ngspice: 35
	Compiler: Visual C++ 1929 without C++ ABI

Build settings:
	KICAD_USE_OCC=ON
	KICAD_SPICE=ON
@radoslav006 radoslav006 changed the title Generate output without refill zones Generate output without zones refill Apr 15, 2023
@radoslav006 radoslav006 changed the title Generate output without zones refill Generate without zones refill Apr 15, 2023
@Bouni
Copy link
Owner

Bouni commented Apr 19, 2023

That is a bug in KiCAD itself and needs to be fixed on the KiCAD side: https://gitlab.com/kicad/code/kicad/-/issues/13135

@Bouni Bouni added the bug Something isn't working label Apr 19, 2023
@radoslav006
Copy link
Author

I see. I just locally commented out the zone refilling for myself.
Maybe this could be also a solution for your repo; in that way the user has choice to fill the zones or not before launching the plugin. The other option is to detect unfilled zones and provide a custom wx pop-up that will ask user to fill or not. But I am not sure if this could be achieved with KiCad API - btw. is there any sensible API documentation available? I am willing to contribute, but have no knowledge of the KiCad API.

If you ask what a mad man do not refill the zones before production, I can show you what a nice copper balancing can be achieved with this (not connected copper balancing is important from a signal integrity perspective) :)
obraz

In the end, you were aware of the problem, so the issue could be closed then, I suppose.

@Bouni
Copy link
Owner

Bouni commented Apr 19, 2023

I think we could add another option in the settings that lets the user turn off the auto filling!

@radoslav006
Copy link
Author

Indeed, a good idea.

@Bouni Bouni linked a pull request May 23, 2023 that will close this issue
@Bouni
Copy link
Owner

Bouni commented May 23, 2023

Done!

@Bouni Bouni closed this as completed May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants