Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespaces in compile constants values cause SWF compilation error #552

Open
itlancer opened this issue Sep 9, 2021 · 2 comments
Open
Labels

Comments

@itlancer
Copy link

itlancer commented Sep 9, 2021

Whitespaces in compile constants values cause SWF compilation error.
So if you have in asconfig.json something like:

"define": [
	/**
	 * String values must be formatted with nested quotes, like "'hello'",
	 because the compiler will attempt to evaluate an expression when it encounters quotes.
	 */
	{"name": "CONFIG::PRODUCT_NAME",	"value": "'App Name'"}
],

It cause
Error exists after running preLaunchTask 'undefined'.

It works fine if you dont' have spaces. For example AppName.
Whitespaces in compile constants works fine with other IDEs.

@joshtynjala
Copy link
Member

I'm not able to reproduce this issue. My compile task is completing correctly.

Your error message is interesting, and points to a potentially larger problem. I don't know why the preLaunchTask value in your tasks.json file would be displayed as undefined instead of the name of the task, even if the compiler failed while running the task. That's kind of strange.

@itlancer
Copy link
Author

@joshtynjala
I have checked with macOS - indeed it works fine.
But with Windows (tested with multiple different devices) it faults as described above.
Without whitespaces all works fine. May be some internal error with Windows command line usage where space split string to different arguments...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants