You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If one selects a wrong app when importing a file from another app, the error reported has no indication that the app might be incorrect.
There should be a help message asking if the user is sure that the file is coming from the selected app.
In this case, a simple check for magic_id plus the mod_version attribute should be enough.
For example, selecting RE5 and trying to import a RE1 file gives:
Error: KeyError: 're5'
Traceback:
File "/blender/3.6/scripts/addons/albam/blender_ui/import_panel.py", line 48, in execute
self._execute(item, context)
File "/blender/3.6/scripts/addons/albam/blender_ui/import_panel.py", line 57, in _execute
bl_container = import_function(item, context)
File "/blender/3.6/scripts/addons/albam/engines/mtfw/mesh.py", line 299, in build_blender_model
materials = build_blender_materials(
File "/blender/3.6/scripts/addons/albam/engines/mtfw/material.py", line 93, in build_blender_materials
mrl = _infer_mrl(context, mod_file_item, app_id)
File "/blender/3.6/scripts/addons/albam/engines/mtfw/material.py", line 862, in _infer_mrl
cb_globals_version = MRL_APPID_CB_GLOBALS_VERSION[app_id]
The text was updated successfully, but these errors were encountered:
Brachi
changed the title
Wrong app_id selection has no clear error message when importing
Wrong app selection has no clear error message when importing
Mar 9, 2024
If one selects a wrong app when importing a file from another app, the error reported has no indication that the app might be incorrect.
There should be a help message asking if the user is sure that the file is coming from the selected app.
In this case, a simple check for magic_id plus the
mod_version
attribute should be enough.For example, selecting RE5 and trying to import a RE1 file gives:
The text was updated successfully, but these errors were encountered: