Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set COMPOSER_HOME #12

Closed
mbrodala opened this issue Jan 29, 2015 · 9 comments
Closed

Add option to set COMPOSER_HOME #12

mbrodala opened this issue Jan 29, 2015 · 9 comments

Comments

@mbrodala
Copy link
Contributor

Instead of the fallback to HOME/.composer one can explicitly set COMPOSER_HOME. This should be an option.

I'm not sure about the best location though. Both composer::$home and composer::project::$home come into mind where the former actually makes more sense but would make it harder for composer::project to use.

Suggestions?

@igalic
Copy link
Contributor

igalic commented Jan 29, 2015

we could set the option in composer::home, and re-use it as default in composer::project

@mbrodala
Copy link
Contributor Author

So you mean defaulting to $composer::home instead of $composer::params::home?

@igalic
Copy link
Contributor

igalic commented Jan 29, 2015

i'm starting to doubt the usfulness of composer::params.

generally, the hierarchy is:

composer::project::foocomposer::foocomposer::params::foo = 'bare constant'

however, composer::params, as a pattern, only makes sense if we're supposed to support (widely) different systems, where these params actually differ.

as it is, we can simplify this chain down to:

composer::project::foocomposer::foo = 'bare constant'

@mbrodala
Copy link
Contributor Author

Alright, I'll gladly go with this.

@igalic
Copy link
Contributor

igalic commented Jan 29, 2015

well, then, please prepare a pull request!

@mbrodala
Copy link
Contributor Author

mbrodala commented Feb 4, 2015

Apparently the current solution yields a warning in case $composer::home is not set:

Warning: Exec[composer-fix-permissions](provider=posix): Cannot understand environment setting "COMPOSER_HOME="

Gotta tweak this.

@igalic
Copy link
Contributor

igalic commented Feb 6, 2015

i think we should establish Pull Requests for everything, i was a bit confused about your push to master :O

(yes, that means i create pull requests for my pushes too.)

@mbrodala
Copy link
Contributor Author

mbrodala commented Feb 6, 2015

Yeah, usually going via PR should be preferred, especially to wait for Travis confirmation. But in this case I have tried it locally on a development setup to actually develop the fix. ;-)

@igalic
Copy link
Contributor

igalic commented Feb 6, 2015

nod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants