Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Make Nurikabe Finish Room a bit more general #820

Closed
Bram28 opened this issue Jun 6, 2024 · 0 comments
Closed

[ENHANCEMENT] Make Nurikabe Finish Room a bit more general #820

Bram28 opened this issue Jun 6, 2024 · 0 comments
Assignees
Labels
enhancement Improvement to existing feature

Comments

@Bram28
Copy link
Member

Bram28 commented Jun 6, 2024

Describe the current behavior of what you're trying to improve. If your enhancement request related to a problem, please also describe the problem.

Right now the Finish Room Case Rule in Nurikabe only applies to rooms that require exactly one more white cell.

Describe the improvement you'd like

It would be nice if the rule could be applied to rooms where any number of whites are still needed.

Of course, the number of possibilities could quickly explode, but we have a maximum number of branches that a case rule could go into, so if it is too many, it won;t allow you ... but it should work for room for which there are, say, 4 options to add the last 2 whites.

I also get the impression that the rule as it currently is implemented, does not create branches that immediately run into a different room, i.e. the rule takes into account black and white squares. I that is fine ... and that will also cut down on the number of possibilities, so all the more reason to generalize this rule a bit.

I also notice the rule is not listed in the Wiki yet .. someone please do so ... and please provide a precise description of how the rule works.

Describe alternatives you've considered

No response

Additional Context

No response

@Bram28 Bram28 added the enhancement Improvement to existing feature label Jun 6, 2024
@zachbonagura zachbonagura self-assigned this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing feature
Projects
None yet
Development

No branches or pull requests

2 participants