Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin crashes on ios 12 #59

Closed
Tallyb opened this issue Jun 17, 2022 · 2 comments
Closed

Plugin crashes on ios 12 #59

Tallyb opened this issue Jun 17, 2022 · 2 comments

Comments

@Tallyb
Copy link

Tallyb commented Jun 17, 2022

Although it is mentioned that this plugin is working with ios 12
https://github.com/BranchMetrics/capacitor-branch-deep-links/blob/master/ios/Podfile#L1
it may in fact crash on ios 12.

The reason being this line: https://github.com/BranchMetrics/capacitor-branch-deep-links/blob/master/ios/Podfile#L7
In certain cases, and depending on cache, it may install Branch 1.42.0 which is not compatible with ios 3.

We fixed this (after 3 days of working on it...) by adding the Branch 1.4.1 as dependency:

in the ios/App/Podfile:

target 'app' do
  capacitor_pods
  pod 'Branch', '1.41.0'  # add this line to install the pod good verison that works with ios 12. 
  # Add your Pods here
end

Suggestion - to comply with ios12, the POD version on the above Podfile, the version should be fixed on 1.41.0, as 1.42 is no longer compliant.

Also filed as issue on the Branch framework: BranchMetrics/ios-branch-deep-linking-attribution#1185

@jf-branch
Copy link

Hi @Tallyb, Closing this out as we have addressed this on the iOS repo: BranchMetrics/ios-branch-deep-linking-attribution#1185 and we have also released 1.43.1 that adds LinkPresentation.framework as a weak dependency in the podspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants