complete switch to RCTEventEmitter. #35
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this module's event emitting is currently broken on latest versions of react (only tested with 0.30+, can't say for previous versions)
unfortunately the documentation isn't up to date but my understanding is that events should no longer be emitted on the global bus and that native modules should now use a subclassed/module-scopped
NativeEventEmitter
as can be seen here and therethe recent switch to RCTEventEmitter only affected the native code. so the current js code was listening on the global bus while the native code was sending events on the RNBranch-scopped bus... this pull request updates the js code to listen on that scopped bus.
cc @nicklockwood (sorry for blindly cc'ing you in here, but i would appreciate if you could confirm this is indeed the new/correct way of communicating via events.)