Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveException.EntityErrors getter throws NullReferenceException #10

Closed
markhewett opened this issue Mar 4, 2015 · 3 comments
Closed

SaveException.EntityErrors getter throws NullReferenceException #10

markhewett opened this issue Mar 4, 2015 · 3 comments

Comments

@markhewett
Copy link

In some cases the_entityErrors variable in SaveException is not being initialized (in my case, I got client side validation errors because my RowVersion field was null on new objects - not sure why that is an error for inserts anyway!), causing the SaveException.EntityErrors getter to throw a NRE. This makes it hard to check for entity errors in error handling code. It should return null instead.
@wardbell
Copy link
Member

You're making good points. Waiting for the tech lead (who is on vacation) to review.

@bmperdue
Copy link

Is this a fix to this issue? I tried it and I am still getting the issue on save.

@steveschmitt
Copy link
Member

Fixed by pull request #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wardbell @markhewett @steveschmitt @bmperdue