Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to reinit height? #16

Closed
Venegrad opened this issue Feb 17, 2021 · 1 comment
Closed

How to reinit height? #16

Venegrad opened this issue Feb 17, 2021 · 1 comment

Comments

@Venegrad
Copy link

If ill use slideDown, and after inside element change height (like add some items in spoiler), after slideUp and slideDOwn will bug, because start animation from old height.

@BrentonCozby
Copy link
Owner

BrentonCozby commented Apr 25, 2021

@Venegrad the library was caching the height, but I saw no good reason to do this since the height is calculated every time a slide is triggered. Therefore, I removed the cached height so it now uses the latest height every time. I've also updated the example to include dynamic heights. Thanks for reporting this issue. You can download the fixed library with v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants