Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data un-marshall fails if FPS is float #4

Open
sam-ulrich1 opened this issue Aug 20, 2020 · 0 comments · May be fixed by #7
Open

Data un-marshall fails if FPS is float #4

sam-ulrich1 opened this issue Aug 20, 2020 · 0 comments · May be fixed by #7

Comments

@sam-ulrich1
Copy link

json: cannot unmarshal number 23.976 into Go struct field .requested_formats.fps of type int

I get the following error in the case that FPS is calculated as a float. This is certainly a less common case but appears to be the result of the original file format from the download process.

I propose changing the FPS value in the specified struct to a float64 to ensure unmarshalling. If the user then wants to truncate to 32bit or some integer it is their discretion

@sam-ulrich1 sam-ulrich1 reopened this Aug 20, 2020
@TheKinrar TheKinrar linked a pull request Apr 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant