Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Switch flake repos to git-submodules #231

Closed
Mephistophiles opened this issue Dec 18, 2022 · 2 comments
Closed

[RFC] Switch flake repos to git-submodules #231

Mephistophiles opened this issue Dec 18, 2022 · 2 comments

Comments

@Mephistophiles
Copy link
Contributor

I saw you moved tree-sitter modules from git-submodules to flakes. But this a little limits the appearance to build from a non-nix build system. Why did you drop support for git-submodules?

@BrianHicks
Copy link
Owner

A couple reasons:

  • submodules have pretty terrible UX in the git command line. Maybe they're better in some client, but we can't rely on that.
  • some Nix things don't support submodules. I don't remember which right now but it was a real pain.

Making symlinks or subtrees would solve this. I chose symlinks because subtrees add a lot of unrelated commits to the repo.

If this changes, I don't think we should go back to submodules, but get rid of embedded grammars altogether as in #88.

@Mephistophiles
Copy link
Contributor Author

Thanks for the clarification!:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants