Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java classes should be in package ukcrobots #1

Open
oversticht opened this issue Apr 30, 2020 · 1 comment
Open

Java classes should be in package ukcrobots #1

oversticht opened this issue Apr 30, 2020 · 1 comment

Comments

@oversticht
Copy link

Hi!
Java requires the folder structure to match the java packages, so core and util should be below the ukcrobots folder. The ukcrobots package is properly included in https://github.com/oversticht/lego-rcx-lejos, which is also configured to compile the other jars (classes, jtools, pcrcxcomm, rcxrcxcomm, regression and vision) from leJOS 2.1 sources using Apache Ant 1.9.14 so Java 5.

@mesheets
Copy link
Member

Hello @oversticht , thank you for the feedback! The code in BrickBot/leJOS-RCX is based on v3.0 RC2, and I have a GitHub Action setup here.

  • If bundled into that, am I following correctly that this code would go in the src/java directory linked here?
  • Might there be any potential issues with that codebase being based on leJOS v3.0 RC2 instead of leJOS v2.1?

Pull requests on BrickBot/leJOS-RCX are welcome. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants