Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow tabulate when CVR parsing fails #859

Open
yezr opened this issue Jun 28, 2024 · 0 comments · May be fixed by #861
Open

Don't allow tabulate when CVR parsing fails #859

yezr opened this issue Jun 28, 2024 · 0 comments · May be fixed by #861

Comments

@yezr
Copy link
Collaborator

yezr commented Jun 28, 2024

RCTab Version: 1.3.999
cvr: CSV CVRs - tab by batch test.csv
config: tab by batch and precinct.json

What Happened

I created an .xlsx CVR to do some testing and accidentally transposed the candidate/ranks. I went to tabulate and in the validation modal clicked 'Check Ballot Counts'. That step failed and correctly showed the errors in the audit.log.
image

But, I was still able to click 'Tabulate' which also, as expected, failed. Once tabulate failed I saw the 'Close and View Errors' button.
image

What I would Expect to Happen

If we know that parsing CVRs failed, can we grey out the tabulate and show the 'Close and View Errors' button?

@artoonie artoonie linked a pull request Jun 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant