Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Spurious StoreOffset call in Kafka Consumer #3055

Closed
iancooper opened this issue Apr 15, 2024 · 0 comments
Closed

[Bug] Spurious StoreOffset call in Kafka Consumer #3055

iancooper opened this issue Apr 15, 2024 · 0 comments
Labels
3 - Done Bug
Projects
Death to Bugs

Comments

@iancooper
Copy link
Member

Describe the bug

There is what looks like a spurious call to consumer.StoreOffset(offset) in l.240 as that would not be needed given we control the offsets via a commit.

To Reproduce

By inspection only

Fix

Delete the spurious line and confirm it still works as we are doing manual commits
@iancooper iancooper added this to Needs triage in Death to Bugs via automation Apr 15, 2024
@iancooper iancooper moved this from Needs triage to Low priority in Death to Bugs Apr 16, 2024
@iancooper iancooper mentioned this issue Apr 16, 2024
Closed
Death to Bugs automation moved this from Low priority to Closed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - Done Bug
Projects
Death to Bugs
  
Closed
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iancooper