Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support setting a service URL when configuring an AWSMessagingGatewayConnection #3109

Open
dhickie opened this issue May 22, 2024 · 3 comments · May be fixed by #3114
Open

[Feature] Support setting a service URL when configuring an AWSMessagingGatewayConnection #3109

dhickie opened this issue May 22, 2024 · 3 comments · May be fixed by #3114
Assignees
Labels

Comments

@dhickie
Copy link

dhickie commented May 22, 2024

Is your feature request related to a problem? Please describe.
When working with SNS, we do local testing using LocalStack. This involves starting a LocalStack container and pointing AWS services in code to the container rather than to a real AWS environment.

When using SNS as an external bus, there's no option to provide a service URL, and so it defaults to a real AWS environment, making testing using LocalStack impossible.

Describe the solution you'd like
When creating an AWSMessagingGatewayConnection instance, support optionally supplying a ServiceURL value.

@iancooper iancooper self-assigned this May 22, 2024
@iancooper iancooper added 0 - Backlog v9 Required for v9 release labels May 22, 2024
@iancooper
Copy link
Member

@dhickie Let's pick this up. Let me know if you want to have a stab at it, or for me to pick it up instead.

@iancooper iancooper changed the title Support setting a service URL when configuring an AWSMessagingGatewayConnection [Feature] Support setting a service URL when configuring an AWSMessagingGatewayConnection May 22, 2024
@dhickie
Copy link
Author

dhickie commented May 22, 2024

@iancooper Happy to take a look at this one. Is one of release/9x or release/9X the branch I should look at for forking?

@iancooper
Copy link
Member

@iancooper Happy to take a look at this one. Is one of release/9x or release/9X the branch I should look at for forking?

Our process is a little borked here TBH. Usually I do the following:

You can do it the other way around if that makes more sense.

@dhickie dhickie linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants