Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible code duplication? #17

Open
MatyasKriz opened this issue Oct 12, 2017 · 0 comments
Open

Possible code duplication? #17

MatyasKriz opened this issue Oct 12, 2017 · 0 comments

Comments

@MatyasKriz
Copy link
Collaborator

At ComponentDelegate.swift:84 we have this:

public weak var ownerComponent: COMPONENT? {
    didSet {
        needsUpdate = stateStorage != nil
    }
}

If I understand the implementation correctly, we want to set needsUpdate to true if the component has a componentState, why isn't then this variable used?

public var hasComponentState: Bool {
    return stateStorage != nil
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant