fix: including Lit table styles in the dom-module #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed one use case: using
<d2l-table-wrapper>
from inside a Polymer element. In that scenario, the styles were getting added to the root document but couldn't pierce the wrapper element's shadow root so weren't getting applied.This change just moves them into the style
dom-module
just like the older d2l-table/d2l-tr/etc. styles.The unfortunate side-effect of all this is that Polymer elements will need to continue to use the Polymer version of d2l-table, and Lit ones will need to use the Lit version -- no mixing and matching. So that kind of goes against how web components work... but I'm justifying it in my mind by thinking of these more as shared styles than a web component. In Polymer the way you share styles is these
dom-module
s and in Lit it's importing style literals into your component. 馃し