Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: including Lit table styles in the dom-module #244

Merged
merged 1 commit into from May 28, 2021
Merged

Conversation

dlockhart
Copy link
Member

I missed one use case: using <d2l-table-wrapper> from inside a Polymer element. In that scenario, the styles were getting added to the root document but couldn't pierce the wrapper element's shadow root so weren't getting applied.

This change just moves them into the style dom-module just like the older d2l-table/d2l-tr/etc. styles.

The unfortunate side-effect of all this is that Polymer elements will need to continue to use the Polymer version of d2l-table, and Lit ones will need to use the Lit version -- no mixing and matching. So that kind of goes against how web components work... but I'm justifying it in my mind by thinking of these more as shared styles than a web component. In Polymer the way you share styles is these dom-modules and in Lit it's importing style literals into your component. 馃し

@dlockhart dlockhart merged commit fbea40b into master May 28, 2021
@dlockhart dlockhart deleted the polymer-fix branch May 28, 2021 14:40
@ghost
Copy link

ghost commented May 28, 2021

馃帀 This PR is included in version 2.8.1 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@ghost ghost added the released label May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants