Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: An easy way to customize control UI #68

Closed
BrikerMan opened this issue Mar 30, 2017 · 13 comments
Closed

Discussion: An easy way to customize control UI #68

BrikerMan opened this issue Mar 30, 2017 · 13 comments

Comments

@BrikerMan
Copy link
Owner

I created BMPlayerCustomControlView to allow users to customize UI easily, but it makes thing worse.
I am planning to refactor the whole player to allow the user easily customize the control UI. There are several ideas:

  1. create a BMPlayerControlView and allow the user to subclass and change the Auto-layout and icon images to customize UI.
  2. use the BMPlayerCustomControlView to customize and simplify the protocol.
@benbahrenburg
Copy link
Contributor

benbahrenburg commented Apr 3, 2017

I heavily use the BMPlayerCustomControlView. I think allowing for a subclass would provide the most flexibility. Do you have any timing on when you will be making these changes?

@BrikerMan
Copy link
Owner Author

@benbahrenburg I am already working on it, and planning to finish by tomorrow if I can. But this will break your code. I chose the second option to create a control view which allows user to subclass and change rather than protocol with message variable and function. Is that ok with you? And I have already add a subtitle function that allows user to show their str subtile with the video.

@BrikerMan BrikerMan mentioned this issue Apr 3, 2017
@benbahrenburg
Copy link
Contributor

@BrikerMan sounds good. Will the default implementation use the same protocol? Figured provides the best documentation as we can just look at the default implementation to see how to implement our own.

@BrikerMan
Copy link
Owner Author

Yes, will provide document and Example~

@BrikerMan
Copy link
Owner Author

@Owl7 @benbahrenburg Try the latest commit and the example. This is custom example BMPlayerCustomControlView.

@BrikerMan
Copy link
Owner Author

@csauvage Check the Custom Control UI 2. Just committed.

@benbahrenburg
Copy link
Contributor

@BrikerMan works perfectly. Thanks for doing this.

@BrikerMan
Copy link
Owner Author

@benbahrenburg could you help me submit BMPlayer to https://github.com/matteocrippa/awesome-swift?

@benbahrenburg
Copy link
Contributor

@BrikerMan ok, will do tomorrow

@benbahrenburg
Copy link
Contributor

@BrikerMan can you do me a favor and slightly update the project description. The awesome swift list has a requirement that the project description doesn't say "Description does not say "written in Swift" or variant "

I would suggest "A video player for iOS, based on AVPlayer, support the horizontal, vertical screen. support adjust volume, brigtness and seek by slide."

@BrikerMan
Copy link
Owner Author

@benbahrenburg ok~

@benbahrenburg
Copy link
Contributor

@benbahrenburg
Copy link
Contributor

@BrikerMan PR merged matteocrippa/awesome-swift#905 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants