-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: An easy way to customize control UI #68
Comments
I heavily use the BMPlayerCustomControlView. I think allowing for a subclass would provide the most flexibility. Do you have any timing on when you will be making these changes? |
@benbahrenburg I am already working on it, and planning to finish by tomorrow if I can. But this will break your code. I chose the second option to create a control view which allows user to subclass and change rather than protocol with message variable and function. Is that ok with you? And I have already add a subtitle function that allows user to show their str subtile with the video. |
@BrikerMan sounds good. Will the default implementation use the same protocol? Figured provides the best documentation as we can just look at the default implementation to see how to implement our own. |
Yes, will provide document and Example~ |
@Owl7 @benbahrenburg Try the latest commit and the example. This is custom example |
@csauvage Check the |
@BrikerMan works perfectly. Thanks for doing this. |
@benbahrenburg could you help me submit BMPlayer to https://github.com/matteocrippa/awesome-swift? |
@BrikerMan ok, will do tomorrow |
@BrikerMan can you do me a favor and slightly update the project description. The awesome swift list has a requirement that the project description doesn't say "Description does not say "written in Swift" or variant " I would suggest "A video player for iOS, based on AVPlayer, support the horizontal, vertical screen. support adjust volume, brigtness and seek by slide." |
@benbahrenburg ok~ |
I created BMPlayerCustomControlView to allow users to customize UI easily, but it makes thing worse.
I am planning to refactor the whole player to allow the user easily customize the control UI. There are several ideas:
BMPlayerControlView
and allow the user to subclass and change the Auto-layout and icon images to customize UI.BMPlayerCustomControlView
to customize and simplify the protocol.The text was updated successfully, but these errors were encountered: