Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings text input is unreadable when using "dark" brightness and light UI theme #5

Open
int3h opened this issue Jun 14, 2016 · 1 comment

Comments

@int3h
Copy link

int3h commented Jun 14, 2016

There's a bug in Gruvbox Plus that causes <text> boxes in Atom's settings windows, search bar, etc., to be unreadable when using a light UI theme (e.g., "One Light") and Gruvbox Plus' "Brightness" setting is set to "Dark".

See screenshot using the "One Light" UI theme that comes with Atom, and Grubox Plus set to "dark" brightness, "hard" contrast, and "no dimmed colors" variant:

screen shot 2016-06-14 at 1 32 44 pm

The cause seems to be that Atom uses 'mini' text-editor controls for settings, et al. <text> input boxes. When Gruvbox Plus is set to "dark", it uses a light color for default text. On normal text-editors, this is fine, because Gruvbox Plus also sets a dark background color. However, on mini text-editors, Atom uses the UI theme's background color, which can be light. This leads to unreadable light text on a light background.

Atom version: 1.9.0-beta0
Gruvbox Plus version: 1.2.3
OS: Mac OS X "El Capitan" v10.11.5

@Briles
Copy link
Owner

Briles commented Jun 14, 2016

Thanks for reporting this!

I've added dc1c593 and published v1.2.4 which makes the UI theme handle coloring the text input color (regex find/replace colors remain unchanged). This should allow any Gruvbox syntax to be used with any UI theme.

I'm going to leave this issue open while I investigate further in hopes of providing a more robust solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants