Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still working? #29

Closed
erropix opened this issue Nov 10, 2020 · 8 comments
Closed

Is this still working? #29

erropix opened this issue Nov 10, 2020 · 8 comments

Comments

@erropix
Copy link

erropix commented Nov 10, 2020

I have tried much time to toggle quotes in the selected string and it did nothing, I tried in JS and PHP files.

@jeremychone
Copy link
Contributor

yes, working for me daily and many other I think.

A while back someone had issues with the key mapping with some foreign keyboard and then they found the solution (do not remember where)

@erropix
Copy link
Author

erropix commented Nov 11, 2020

It is not working for me, I even tried running the command from the commands popup and got no results.

@jeremychone
Copy link
Contributor

I will try to look at it, but I probably use it 10 to 50 times a day, and always working.

What is your OS / VSCode language / keyboard config?

@erropix
Copy link
Author

erropix commented Nov 11, 2020

I am using on Windows 10 English System and keyboard language.
Hotkeys shouldn't be a problem, as executing the command directly doesn't work.

Maybe I am using it wrong since there are no instructions on how to use it.

@jeremychone
Copy link
Contributor

image

Perhaps you select what you want to toggle. It's the other way around, you put your cursor in the quote pair you want to toggle. This allows to "exclude" was you do not want to count.

@erropix
Copy link
Author

erropix commented Nov 11, 2020

you put your cursor in the quote pair you want to toggle

This was the most needed instruction, I was selecting the whole string, then I tried selecting the quotes, but nothing worked.
When I put the cursor between the two quotes, it worked fine.

Please add a better description for this great addon 👍

@jeremychone
Copy link
Contributor

Very good point. I need to do a little animated gif, that shows how it works.

There is a reason for this behavior, because, this way, the logic does not have to be too complex and the human can give the necessary hint.

But good point, about the documentation deficiency. Will fix it in the next coming days.

@jeremychone
Copy link
Contributor

Closing, see #30.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants