Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PV6 VisuSubjectType is not used to provide proper orientation in combination with VisuSubjectPosition #25

Closed
gdevenyi opened this issue Jul 14, 2020 · 2 comments

Comments

@gdevenyi
Copy link
Collaborator

In the case of PV6, there are several options for input subject type:
image

When combined with VisuSubjectPosition, these need to properly orient the scan in standardized coordinates.

Take for example a primate in "Head First Supine" vs a Rodent in "Head First Supine", the brain will be rotated by 90 degrees relative to each other.

This will also probably require some special casing for PV5, as it does not seem to have an option to set this parameter and always specifies SUBJECT_type=Human

@dvm-shlee
Copy link
Member

dvm-shlee commented Jul 24, 2020

@gdevenyi It actually integrated but just not thoroughly tested, so I'm not sure it works correctly,
Currently, I only have a dataset with Quadruped but apply -90 degree on X-axis and 180 degrees for Y-axis to correct the orientation for Biped. (For Quadruped - Head_Supine is located 180degree for Z-axis, so I think overall the result is the same as you suggested). Not sure the PV6 handle 'OtherAnimal' differently, because I was only able to find Biped and Quadruped from the 'VisuSubjectType' metadata field so far (from the manual).
The code is located at brkraw.lib.utils.build_affine_from_orientation_info
In case this is not functioning as you expected, could you provide any sample that shows the issue?

@gdevenyi
Copy link
Collaborator Author

Ah sorry, I see you have some corrections. I've gotten confused as the scanner console does not have the same options as the code and I was searching for the scanner options in the source.

I think for Other (and maybe Phantom) no correction should be applied? I'm pretty sure the orientation settings are disabled at the console. As for OtherAnimal, at least for their example a snake has the same brain-to-body geometry as a quadruped.

As I mentioned elsewhere I'm collecting a complete dataset of a phantom with all the various settings flipped around in combinations to test all configs.

@gdevenyi gdevenyi closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants