Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exclude = () for DRF 3.3 compatability #27

Closed
wants to merge 1 commit into from

Conversation

resalisbury
Copy link

@resalisbury resalisbury commented Nov 3, 2016

"Serializers must include either a fields option, or an exclude option."
source: http://www.django-rest-framework.org/topics/3.5-announcement/#modelserializer-fields-and-exclude

alternate solutions proposed here: #26

@resalisbury resalisbury changed the title Update serializer.py add exclude = () for DRF 3.3 compatability Nov 3, 2016
@Brobin
Copy link
Owner

Brobin commented Nov 3, 2016

"Explicit is better than implicit". I like the fields version better, if we can figure out that it would be much better.

@resalisbury
Copy link
Author

agree. it just happens to be more work :(. I'll play around with it a bit more...

@auvipy
Copy link

auvipy commented Nov 8, 2016

what about using 'all'

@Brobin
Copy link
Owner

Brobin commented Nov 8, 2016

@auvipy I don't belive all works with the versions of DRF that I'm supporting. I guess that could be up for discussion. Do I even need to support old versions of DRF?

@auvipy
Copy link

auvipy commented Nov 8, 2016

no you shouldn't

@resalisbury
Copy link
Author

re: supporting older version. I wouldn't worry about it. drf-generators is for quickly creating a new api from scratch, not for generating code for a legacy application. If you're creating a new api, you should be using the latest version of things...

@Brobin
Copy link
Owner

Brobin commented Nov 8, 2016

Agreed. Okay, so let's try the all route. In this case could you also update the travis yml to not build the older versions of drf? That way it passes.

@Brobin
Copy link
Owner

Brobin commented Nov 28, 2016

Any update on this?

@resalisbury
Copy link
Author

Busy with other things for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants