Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on conversion factors to provide for the ability to pass in params, rather than pre-calculated values. #212

Open
thenetworkgrinch opened this issue Jun 14, 2024 · 0 comments

Comments

@thenetworkgrinch
Copy link
Contributor

The module configs will go from

"conversionFactors": {
"drive": 0,
"angle": 0
}

to

"conversionFactor": {
"drive": {"gearRatio": 0, "diameter": 4, "factor": 0},
"angle": {"gearRatio": 0, "factor": 0}
}

factor is optional. The original method will stay for a year then be removed per standard deprecation policies, anyone using the old JSON format WILL see a deprecation warning.

factor will be autogenerated based off of the given elements of the decomposed conversion factor. An error will occur if you define factor while also defining the decomposed value's.

There will be an undocumented parameter ticks to aid in very far EDGE cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant