Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BS becomes unresponsive after two file changes on Node 11 #1626

Closed
2 of 10 tasks
DimitarNestorov opened this issue Oct 30, 2018 · 10 comments
Closed
2 of 10 tasks

BS becomes unresponsive after two file changes on Node 11 #1626

DimitarNestorov opened this issue Oct 30, 2018 · 10 comments

Comments

@DimitarNestorov
Copy link

Issue details

It seems that there is some kind of endless loop triggered after a couple of file changes.

Here's a video showing off the issue: https://youtu.be/MfnATcrsXt0
It's quite long, here are some timestamps:
00:00 - I run Browser Sync
02:30 - I create test.js
02:39 - I change test.js
03:16 - I change test.js again
03:24 - Browser Sync becomes unresponsive

I tested latest Node 10, the issue doesn't occur there.

Steps to reproduce/test case

  1. Clone https://github.com/dimitarnestorov/browsersync-node11.git
  2. Install dependencies
  3. Run node script.js
  4. Create a random file inside the build folder
  5. Make a change inside the new file
  6. Make another change inside the new file

Please specify which version of Browsersync, node and npm you're running

  • Browsersync [ 2.26.3 ]
  • Node [ 11.0.0 ]
  • Npm [ 6.4.1 ]

Affected platforms

  • linux
  • windows
  • OS X
  • freebsd
  • solaris
  • other (please specify which)

Browsersync use-case

  • API
  • Gulp
  • Grunt
  • CLI
@rawzone
Copy link

rawzone commented Oct 30, 2018

Also seeing this when using browsersync with laravel-mix running under Linux.

  • Browsersync [2.26.3]
  • Node [11.0.0]
  • Yarn [1.10.1] [1.12.1]

Same behavior as on the YouTube video @DimitarNestorov posted how ever the number of times before it stops responding varies for me for each time i relaunch browsersync.

Have tried to disable all ipv6 networking to ensure it was not a problem resolving localhost / 127.0.0.1 but does not seem to have made any difference.

Edit: Just upgraded Yarn to latest version, this didn't change anything.

@joemaller
Copy link
Contributor

I think I'm seeing the same thing. No luck downgrading browsersync, but after switching node down to v10.x (and rebuilding node_modules) browsersync has been working smoothly for a couple hours.

@JuanDMeGon
Copy link

Facing the same with Node 11.0.0 on Windows 10 x64.
Just in case. I am using Laravel mix as well (which uses webpack) and Browser-sync ^2.26.3 along to browser-sync-webpack-plugin ^2.2.2.
After removing NPM 11.0.0 and install Node 10.13.0LTS, then remove node_modules and package-lock.json (just in case) it works as expected again.

@WuglyakBolgoink
Copy link

same :(

@keithws
Copy link

keithws commented Nov 6, 2018

Same issue here but I am not using Laravel nor weback. I have it configured to watch a few thousand static files. Works fine on Node 10.x. Locks up after a few minutes on Node 11.x. Browser-sync 2.26.3.

@WuglyakBolgoink
Copy link

FYI: yesterday I upgraded my NodeJS version with v11.1.0 -> BS working again as before. 👍

Please test this.

@waltercruz
Copy link

Yes, node 11.1 solved the issue to me.

@roberthallatt
Copy link

Also solved it for me

@rawzone
Copy link

rawzone commented Nov 9, 2018

Also confirmed fixed after upgrading node to v11.1.0.

@jmcbee
Copy link

jmcbee commented Nov 12, 2018

I thought I was going crazy. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants