Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should have an option to sync scroll-top position, instead of proportional #64

Closed
shakyShane opened this issue Feb 6, 2014 · 7 comments · Fixed by #69
Closed

should have an option to sync scroll-top position, instead of proportional #64

shakyShane opened this issue Feb 6, 2014 · 7 comments · Fixed by #69

Comments

@shakyShane
Copy link
Contributor

We currently have proportional scroll - which is great in most cases but it would sometimes be nice to sync scroll only based on the scroll top position.

I suggest we keep the current method, and add scrolltop as an option.

@hugooliveirad
Copy link

Do not see any use case. Do you?

Would be simple to implement

@shakyShane
Copy link
Contributor Author

Sometimes I want to sync windows exactly at the same top position - for example, when you want to see how an element looks at exactly the top of each device...

@hugooliveirad
Copy link

Agreed

@shakyShane
Copy link
Contributor Author

@hugooliveirad
Copy link

Not really. I edited the browser-sync client script that is into grunt-browser-sync of my project. Sorry. I will checkout unintended changes.

@shakyShane
Copy link
Contributor Author

1 final thing, for this to work it needs to be set as a default here https://github.com/shakyShane/browser-sync/blob/master/lib/index.js#L12.

After that I'm happy to merge over a PR :)

@hugooliveirad
Copy link

PR fixes this, @shakyShane. Sorry for the unintended changes ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants