Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGX does not work with CKEditor and other alt. RTE's #67

Closed
danyaPostfactum opened this issue Feb 4, 2013 · 13 comments
Closed

MIGX does not work with CKEditor and other alt. RTE's #67

danyaPostfactum opened this issue Feb 4, 2013 · 13 comments

Comments

@danyaPostfactum
Copy link

Currently there is no way to dynamically load and unload rte for specific fields.

@exside
Copy link
Contributor

exside commented Feb 4, 2013

Aaah, we're getting closer to that general RTE & MIGX Problem...but why is TinyMCE working?

@danyaPostfactum
Copy link
Author

Because https://github.com/Bruno17/MIGX/blob/master/core/components/migx/elements/tv/migx.tpl#L238

I have some thoughts about improving MODX rte integration API, but we have to wait for MODX 2.3. That's not good...

@Bruno17
Copy link
Owner

Bruno17 commented Feb 4, 2013

here's the part which inits tinyMCE after loading the window:

https://github.com/Bruno17/MIGX/blob/master/core/components/migx/templates/mgr/updatewindow.tpl#L235

think here needs something to be done

@exside
Copy link
Contributor

exside commented Feb 4, 2013

lol, or both of them? Looks like the same code in 2 different files^^...damn extjs, I'm really no help there =/. What about that (seemingly) more generic .loadRTE() method that's commented out? Does it exist and if yes could it be combined with system setting which_editor?

@danyaPostfactum
Copy link
Author

We can use something like

    this.rtes = this.el.query('.modx-richtext');
        for (var i = 0; i<this.rtes.length; i++) {
            MODx.loadRTE(this.rtes[i].id);
        }

But I can not understand how do you @Bruno17 unload rte...

@Bruno17
Copy link
Owner

Bruno17 commented Feb 4, 2013

good question, was long ago since I added the tinyMCE functionality into MIGX

your code is working, but only the first time, I open the window.
The next times there is just a small textarea left.

@danyaPostfactum
Copy link
Author

your code is working, but only the first time

I know that. Thats why we need the way to unload RTE. I need it for AjaxManager extra also.
By the way, MIGX seems to work with AjaxManager :) But there is still little bug.
@Bruno17 , after using modal window Add Item, your window should be destroyed.

Execute

Ext.getCmp('modx-content').removeAll()

in the browser console. You will see that you window will not be destroyed. You should either destroy the window on hide (or close, I dont remember) event, or listen modx-panel-resource for beforedestroy event and cleanup MIGX.

Back to the issue. I proposed MODx.unloadRTE(id) for TinyMCE.

I propose to call MODx.unloadRTE when available , otherwise remove TinyMCE instances directly.

When do you plan to release next version of MIGX? I would like it to work with CKEditor. If you have no time, I'll try to resolve this issue myself and send my patch to you.

@isaacniebeling
Copy link
Contributor

@danyaPostfactum Did you end up doing any further work on this?

@fkabs
Copy link

fkabs commented Jun 8, 2013

Hi guys,

will there be any fix that we can use CKEditor with MIGX?

I'm currently working on a huge project and the last thing before i can go live is this fix.

Unfortunately i can't switch to TinyMCE for certain reasons so may I ask you if there will be a fix, when can we expect that?

@Bruno17
Copy link
Owner

Bruno17 commented Jun 8, 2013

this feature (CKEditor-tvtype for MIGX) will be added, latest as soon as a customer requires it for a payed project

@Bruno17
Copy link
Owner

Bruno17 commented Jun 11, 2013

fkabs and other guys, I think you are lucky and ckeditor should work now with MIGX

@Bruno17 Bruno17 closed this as completed Jun 11, 2013
@exside
Copy link
Contributor

exside commented Jun 11, 2013

yess, thank you so much! Will try out asap!

@fkabs
Copy link

fkabs commented Sep 10, 2013

works like a charm
thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants