Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make computation deterministic if possible. #70

Open
jdumas opened this issue Mar 1, 2023 · 0 comments
Open

Make computation deterministic if possible. #70

jdumas opened this issue Mar 1, 2023 · 0 comments

Comments

@jdumas
Copy link
Contributor

jdumas commented Mar 1, 2023

I see that geogram started using C++11's random number generator in mesh_reorder, which is good! (Even if you don't like the API :p). However, I am not a fan of using std::random_device to initialize the rng, as this automatically makes the function call non-deterministic. For most geometry processing application it is not needed. If anything, at least it should be an option given to the user.

There are also more complicated algorithms that can be made deterministic for a small extra cost, e.g. CVT computation. I did some changes to geogram in that direction when I was at nTopology. See commit 84c58ff and commit 6be641b for my changes at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant