Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32][BUG] Not working with ESP32 Arduino V2.0.0 #40

Open
BrushlessPower opened this issue Sep 27, 2021 · 6 comments
Open

[ESP32][BUG] Not working with ESP32 Arduino V2.0.0 #40

BrushlessPower opened this issue Sep 27, 2021 · 6 comments
Labels
Done Done but not commited
Milestone

Comments

@BrushlessPower
Copy link
Owner

Code doesnt compile with ESP32 Arduino Core V2.0.0

@BrushlessPower BrushlessPower added the inProgress already working on that label Sep 27, 2021
@emilverwoerd
Copy link

I bought a couple of M5Stack C3U boards I thought something to play with and put this code on a small form factor. However these boards are only usable with v2.x since they are so new.

Is there a change this framework would be updated to v2.x

@BrushlessPower
Copy link
Owner Author

Yes,

i have a local version running with the actual ESP32 core V2.x.x

The are just some Variable names that changed from V1.X.X to V2.X.X.
These Names have to be changed.
I'll try to work on the new version next week. There are a couple of changes and Bug fixes to do.

i just looked at the Code: maybe it just one line:

in SBUS_usart_ESP32.cpp
in void SBUS2_uart_setup()

change

ESP_ERROR_CHECK(uart_set_line_inverse(uart_num, UART_INVERSE_RXD|UART_INVERSE_TXD));

to

#if(ESP_ARDUINO_VERSION_MAJOR == 2)
ESP_ERROR_CHECK(uart_set_line_inverse(UART_NUM_2, UART_SIGNAL_TXD_INV | UART_SIGNAL_RXD_INV)); // V2.0.0
#else
ESP_ERROR_CHECK(uart_set_line_inverse(UART_NUM_2, UART_INVERSE_RXD | UART_INVERSE_TXD)); // V1.6.0
#endif

@BrushlessPower
Copy link
Owner Author

It need some more lines

i will upload my local changes for testing in the next minutes

@BrushlessPower BrushlessPower added Done Done but not commited and removed inProgress already working on that labels Mar 10, 2022
@ericlangel
Copy link
Collaborator

it should work with the actual master branch

after testing i can make a release and make it available in library manager

@emilverwoerd
Copy link

Thx for the quick fixes. I tried to compile it and that works. However with boad ESP32C3 selected it doesn't work its missing stuff

@ericlangel
Copy link
Collaborator

Oh dear...

never tried. I opened issue #44 for that

@ericlangel ericlangel added this to the Release V1.3 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Done but not commited
Projects
None yet
Development

No branches or pull requests

3 participants