Merge pull request #48 from theorm/bugfix/wrap-callback

Triggering callback in wrap after it was queued
jaredwray · Apr 18, 2016 · 427ac6a · 427ac6a
2 parents bdfcbc2 + e9c4f0a
commit 427ac6a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/lib/caching.js b/lib/caching.js
@@ -107,7 +107,8 @@ var caching = function(args) {
                     }
 
                     if (!self._isCacheableValue(data)) {
-                        return cb();
+                        callbackFiller.fill(key, null, data);
+                        return;
                     }
 
                     self.store.set(key, data, options, function(err) {

diff --git a/test/caching.unit.js b/test/caching.unit.js
@@ -688,6 +688,27 @@ describe("caching", function() {
                     });
                 });
             });
+
+            context("when wrapped function returns a non cacheable value once", function() {
+                it("second call to 'wrap' triggers the callback", function(done) {
+                    var key = support.random.string();
+
+                    // 1.
+                    cache.wrap(key, function(cb) {
+                        cb(null, undefined);
+                    }, function(err, result) {
+                        assert.equal(result, undefined);
+                    });
+
+                    // 2.
+                    cache.wrap(key, function(cb) {
+                        cb(null, undefined);
+                    }, function(err, result) {
+                        assert.equal(result, undefined);
+                        done();
+                    });
+                });
+            });
         });
 
         describe("when called multiple times in parallel with same key", function() {