Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add package.json browser entry and browser.js #148

Closed
wants to merge 1 commit into from
Closed

add package.json browser entry and browser.js #148

wants to merge 1 commit into from

Conversation

caub
Copy link

@caub caub commented Nov 15, 2020

It allows to ignore this dependency on browser, for example using webpack target: browser or rollup node-resolve browser option

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.337% when pulling 47d247e on caub:browser into 00e688c on BryanDonovan:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.337% when pulling 47d247e on caub:browser into 00e688c on BryanDonovan:master.

@caub caub mentioned this pull request Nov 15, 2020
Closed
@caub
Copy link
Author

caub commented Nov 16, 2020

not worth, dependencies can be skipped by bundlers using 'external' options

@caub caub closed this Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caub @coveralls