Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime and stdlib strictly separate #3164

Closed
bobzhang opened this issue Nov 23, 2018 · 4 comments
Closed

Make runtime and stdlib strictly separate #3164

bobzhang opened this issue Nov 23, 2018 · 4 comments
Labels
stale Old issues that went stale

Comments

@bobzhang
Copy link
Member

The only remaining piece is runtime support for exception

isCamlExceptionOrOpenVaraint is used in [@bs.open]
internalToOCamlExcepiton is used in runtime
Error is expected to expose to normal users.

It may makes sense to make JsError a built-in exception

@bobzhang
Copy link
Member Author

bobzhang commented Dec 3, 2018

Remaing work:

  • handle cmj properly
make[1]: *** No rule to make target `../runtime/js.cmj', needed by `test_literals.cmj'.  Stop.

Note that cmj missing is more serious, see this issue:

Curry.cmj not found, cmj format is generated by BuckleScript
  • make a separate directory
    Note that this is actually a deficiency of the ocaml compilier driver
    (if we only support this in 4.06 we can preload cmi to avoid further complicate directory layout)
  • Test the idea that others is indeed independent on runtime

@aaronshaf
Copy link

Is this still planned? :)

@bobzhang
Copy link
Member Author

bobzhang commented Feb 15, 2020 via email

@stale
Copy link

stale bot commented Feb 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Old issues that went stale label Feb 4, 2022
@stale stale bot closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Old issues that went stale
Projects
None yet
Development

No branches or pull requests

2 participants