New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Belt] Make comparable label-less #2565
Conversation
It's a single arg, so reduces the burden of using that pattern a little. I'll update the docs after this
cc @cristianoc |
I thought about this. The thing is that when creating hashtbl, you need to pass |
It's not inconsistent not to have a label, especially when the call's name is module IntCmp = (
val Belt.Id.comparable((x: int, y) => Pervasives.compare(x, y))
);
let s = make(~id=(module IntCmp)); |
Yeah I think |
Discussed offline |
See rescript-lang#2565 which removed it. rescript-lang#2589 deprecates comparable, so we can just put the label back to avoid unnecessary churn the next release
It's a single arg, so reduces the burden of using that pattern a little.
I'll update the docs after this