fix #2303 #2566
Merged
fix #2303 #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is a more serious issue than #2303 described, previously, when user create a local module which happens to be a runtime module, it would cause issues. This PR fix such issues.
TODO: error out when user create toplevel modules
whose name happens to be runtime modules (in bsb)
Note in our runtime support: suppose
Caml_objis called directly and instrumented by the compiler, it should be fine. On user land, user could not callCaml_objdirectly, the only way to createCaml_objis to define a global module and call it which should be disallowed.