Fix typos in Belt Module overview #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jasonmendes , thanks for your interest in contribution. The original source of documentation is here: https://github.com/BuckleScript/bucklescript/blob/master/jscomp/others/belt.ml#L26 |
|
Hey @bobzhang Ah, sorry I missed that, and thank you for pointing that out! 🙇♂️ Yes, I will amend the changes to be there. |
chenglou
added a commit
to chenglou/rescript-compiler
that referenced
this pull request
Mar 13, 2018
Complements rescript-lang#2607
Merged
|
@jasonmendes Thanks for the PR! I'll spare you a little trouble and to the changes to the source in #2615. Thanks again =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I found a few small typos in the documentation for the Belt module overview. I read through the contribution guidelines, but if I missed anything, I'd be glad to know.