Bool const in lambda rebased #2662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 20, 2018 10:06
Minimal extension on the bucklescript side to still compile to numbers, just to check that all tests pass. Next, compile to booleans.
Emit booleans instead of integers, and reveal that the type of Js.boolean is the same as bool. So this should be a non-breaking change but allow to omit the conversion between Js.boolean and bool.
The translation of || and && used to return 0/1 instead of false/true. Added tests that would have failed before the change.
In the generated .js files there are no more occurrences of ``` /* false */0 ``` or ``` /* true */1 ```
This does not change the generated files.
This was referenced Mar 20, 2018
|
landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing #2437: a complete set of changes to represent booleans as
trueandfalsein js.