Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-6924] Empty .update() call detected error displayed when updating a table record from the side panel #10387

Closed
kyousry opened this issue Apr 22, 2023 · 5 comments
Assignees
Labels
bug Something isn't working firestorm Data/Infra/Revenue Team linear

Comments

@kyousry
Copy link

kyousry commented Apr 22, 2023

-------------------environment details
I am using the free plan on the cloud
version of Budibase: 2.5.7
Data Source: External MySQL Cloud Server
Tenant ID: test500
app name: my-first-app
OS: windows
Browser: Chrome 112.0.5615.121

-------------------bug description
when trying to update a table from the side panel
it displays a red popup with the below message:
Empty .update() call detected! Update data does not contain any values to update. This will result in a faulty query. Table: teams2. Columns: .

-------------------bug details
the row is updated though
I can see the correct/expected new value after refresh
so it displays the error, plus update the row.

the table I am trying to update is (employees) linked to another (teams) via one to many relationship

steps to reproduce
display a screen with a table block
click one row of the table
sid epanel shows
update values
press save
error shows
table gets updated

Expected behaviour
error should not be displayed

BUDI-6924

@kyousry kyousry added the bug Something isn't working label Apr 22, 2023
@mike12345567 mike12345567 changed the title Empty .update() call detected error displayed when updating a table record from the side panel [BUDI-6924] Empty .update() call detected error displayed when updating a table record from the side panel Apr 25, 2023
@shogunpurple
Copy link
Member

@kyousry if possible, could you please share your database schema with us or an app export, so we can debug?

@mike12345567 mike12345567 added the firestorm Data/Infra/Revenue Team label Apr 25, 2023
@kyousry
Copy link
Author

kyousry commented Apr 25, 2023

here is the DB schema, I tried with both postgres and MySQL , both show the same error
below is Postgres schema

CREATE TABLE IF NOT EXISTS teams (
id SERIAL PRIMARY KEY,
name VARCHAR(255) NOT NULL
);

CREATE TABLE IF NOT EXISTS employees (
id SERIAL PRIMARY KEY,
last_name VARCHAR(255) NOT NULL,
first_name VARCHAR(255) NOT NULL,
title VARCHAR(255) NOT NULL,

reporting_to INT NOT NULL,
team_id INT,

CONSTRAINT fk_employee 
    FOREIGN KEY(team_id)  
    REFERENCES teams(id) 

);

INSERT INTO teams (name) VALUES ('CRM');
INSERT INTO teams (name) VALUES ('Support');
INSERT INTO teams (name) VALUES ('Testing');

INSERT INTO employees ( first_name, last_name, title, reporting_to, team_id)
VALUES ( 'Khaled' , 'Ahmed' , 'Team Manager', 2, 1);

INSERT INTO employees ( first_name, last_name, title, reporting_to, team_id)
VALUES ( 'Aya' , 'Fahmy' , 'Senior Developer', 1, 2);

@adrinr adrinr self-assigned this May 23, 2023
@adrinr
Copy link
Collaborator

adrinr commented May 23, 2023

Hello @kyousry. I could not reproduce the issue, neither using MySQL nor Postgres. Could you please provide an app export to be able to reproduce it from our end?

@pierreboudes
Copy link

Hi, I have the same bug which popped while I was investigating another one. I can share an export and/or fill my own detailed issue as you prefer. The bug arise when creating a new "organisation" linked to two "persons" via a one to many relationship, on a self hosted docker-compose based installation (freshly updated) while using postgresql, and a list view template.

@adrinr
Copy link
Collaborator

adrinr commented Jun 23, 2023

Closed as duplicated of #10688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firestorm Data/Infra/Revenue Team linear
Projects
None yet
Development

No branches or pull requests

5 participants