Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-6987] Unexpected undo when editing inputs within the design view. #10561

Closed
1 task done
ConorWebb96 opened this issue May 12, 2023 · 2 comments
Closed
1 task done
Assignees
Labels
avalanche OSS team bug Something isn't working linear Medium priority Created by Linear-GitHub Sync

Comments

@ConorWebb96
Copy link
Contributor

Checklist

  • I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Self
    • Method: docker compose
    • Budibase Version: 2.6.8
    • App Version: 2.6.8

Describe the bug
Undo has issues whenever editing content within an input on the design view. E.g. editing a JS binding, if you hit the shortcut key while working with these it will occasionally undo a random component change/amend or even delete it. Instead of being fixed to the current area you are working in.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the design view of any app.
  2. Add some components
  3. Edit bindable areas for example: default value on a input field
  4. Write some text and hit the shortcut key for undo
  5. See some components being removed as well as the text you are working on.

Expected behavior
Prevent app undos whenever focused inside a bindable areas. This will prevent loss of progress and also prevent frustrating circumstances where certain previously setup features are broken because components have been changed or removed.

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser Brave
  • Version v1.51.114

From SyncLinear.com | BUDI-6987

@ConorWebb96 ConorWebb96 added bug Something isn't working Medium priority Created by Linear-GitHub Sync labels May 12, 2023
@aptkingston
Copy link
Member

Just to clarify we don't offer any sort of undo functionality while editing text or bindings - if you press our undo shortcut at any time then it'll undo your latest "budibase" change. I imagine this is just doubling up with some browser default functionality which is also undoing some typing with the same shortcut.

I think your suggestion of disabling undo while an input is focused should probably work just fine, because I can't think of anywhere in the design section that you might still want an undo while something is focused. We could also try to swallow key press events that originate from inside text inputs but I reckon checking globally if something is focused should work.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity for 60 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
avalanche OSS team bug Something isn't working linear Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants