You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched budibase discussions and github issues to check if my issue already exists
Hosting
Self
Method: docker compose
Budibase Version: 2.6.8
App Version: 2.6.8
Describe the bug
Undo has issues whenever editing content within an input on the design view. E.g. editing a JS binding, if you hit the shortcut key while working with these it will occasionally undo a random component change/amend or even delete it. Instead of being fixed to the current area you are working in.
To Reproduce
Steps to reproduce the behavior:
Go to the design view of any app.
Add some components
Edit bindable areas for example: default value on a input field
Write some text and hit the shortcut key for undo
See some components being removed as well as the text you are working on.
Expected behavior
Prevent app undos whenever focused inside a bindable areas. This will prevent loss of progress and also prevent frustrating circumstances where certain previously setup features are broken because components have been changed or removed.
Desktop (please complete the following information):
Just to clarify we don't offer any sort of undo functionality while editing text or bindings - if you press our undo shortcut at any time then it'll undo your latest "budibase" change. I imagine this is just doubling up with some browser default functionality which is also undoing some typing with the same shortcut.
I think your suggestion of disabling undo while an input is focused should probably work just fine, because I can't think of anywhere in the design section that you might still want an undo while something is focused. We could also try to swallow key press events that originate from inside text inputs but I reckon checking globally if something is focused should work.
Checklist
Hosting
Describe the bug
Undo has issues whenever editing content within an input on the design view. E.g. editing a JS binding, if you hit the shortcut key while working with these it will occasionally undo a random component change/amend or even delete it. Instead of being fixed to the current area you are working in.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Prevent app undos whenever focused inside a bindable areas. This will prevent loss of progress and also prevent frustrating circumstances where certain previously setup features are broken because components have been changed or removed.
Desktop (please complete the following information):
From SyncLinear.com | BUDI-6987
The text was updated successfully, but these errors were encountered: