Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-7117] Issues with Onchange update record events #10693

Closed
adamkingsbury opened this issue May 25, 2023 · 2 comments
Closed

[BUDI-7117] Issues with Onchange update record events #10693

adamkingsbury opened this issue May 25, 2023 · 2 comments
Labels
actions Relating to Budibase app actions bb-components bug Something isn't working env - production Bug found in production forms linear

Comments

@adamkingsbury
Copy link
Contributor

adamkingsbury commented May 25, 2023

Checklist

  • [x ] I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Self
    • Method: docker compose
    • Budibase Version: tested in 2.5.5 (works as expected), 2.6.22 (issues occur)
  • Cloud
    • Tenant ID: logikloud.budibase.app

Describe the bug
I have designed a number of screens to simulate a basic editable data grid or table utilising a pattern of
dataprovider -> repeater -> form -> text, date and other fields

each field is set up with an onchange event to save the record

In prior versions (v2.5.5 tested) this worked as expected. When a user moved away from an edited cell, the record would save the update and display the updated values. It appears some time soon after version 2.5.5 this no longer works depending on the way a user moves from an edited cell, the save update process may now be triggered either once or twice, and may result in a failed save (without error)

To Reproduce
Steps to reproduce the behavior:

  1. Create a new blank app with sample data.
  2. Create a new screen with the following layout:

All of the fields have the same action set:

  1. The following tests can be performed to identify the varying behaviour of the on change event:

Expected behavior
In all cases when a users has modified a value in a field, then moves away, either by clicking another field, clicking outside, or by tabbing to the next field, the on change event should be triggered only once and should result in the record being saved successfully.

App Export
Can provide an export of my test app if required....

Desktop (please complete the following information):

  • OS: Windows
  • Browser Microsoft Edge
  • Version 113.0.1774.50 (Official build) (64-bit)

From SyncLinear.com | BUDI-7117

@adamkingsbury adamkingsbury added the bug Something isn't working label May 25, 2023
@adamkingsbury
Copy link
Contributor Author

Hi I can see that there hasn't been a lot of movement on this in the last couple of weeks. Is there anything else I can do/provide to support this issue?

@melohagan melohagan added env - production Bug found in production bb-components actions Relating to Budibase app actions forms linear labels Jun 13, 2023
@melohagan melohagan changed the title Issues with Onchange update record events [BUDI-7117] Issues with Onchange update record events Jun 13, 2023
@melohagan
Copy link
Collaborator

Hey @adamkingsbury Thank you very much for the detailed bug report. I was able to reproduce the issue.

It may be worth simply having a save button for your form in the meantime,

What may be occurring in this instance is that because you are performing a Save Row action within the On Change, it may be refreshing the Data provider, which in turn is then triggering another on change.

It could be something to do with the timing of actions, but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Relating to Budibase app actions bb-components bug Something isn't working env - production Bug found in production forms linear
Projects
None yet
Development

No branches or pull requests

2 participants