Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-7165] Multiple loop steps can be added to an automation step causing loops to silently fail #10961

Closed
1 task done
andz-bb opened this issue Jun 19, 2023 · 0 comments
Closed
1 task done
Labels
bb-automations Budibase Automations related work bug Something isn't working env - production Bug found in production firestorm Data/Infra/Revenue Team High priority Created by Linear-GitHub Sync

Comments

@andz-bb
Copy link
Contributor

andz-bb commented Jun 19, 2023

Checklist

  • I have searched Budibase discussions and GitHub issues to check if my issue already exists

Hosting

  • Self
    • Method: docker compose
    • Budibase Version: 2.7.21
    • App Version: 2.7.21

Describe the bug
Multiple loop steps can be added to a single automation step as the button to add the loop is still clickable when a loop is already present. This causes the step to not loop over anything.

To Reproduce
Steps to reproduce the behaviour:

  1. Create an automation
  2. Add a step with a loop
  3. Verify it works
  4. Click Add Looping on the same step
  5. Another loop step is added behind the scenes, automation now loops over nothing returning "status": "no_iterations" on the response

Expected behaviour
After adding looping to a given automation step, the Add Looping button for that step should be disabled or hidden.

Screenshots
working automation object

SCR-20230619-q55.png

Add Looping step still clickable

SCR-20230619-q5f-2.png

Automation steps after clicking Add Looping again (UI looks identical)

SCR-20230619-q60.png

automation test result when two loops are in place

SCR-20230619-q6b.png

infinite loops :)

image.png

App Export

fruity loops-export-1687197109430.tar.gz

Context

#10902

From SyncLinear.com | BUDI-7165

@andz-bb andz-bb added bb-automations Budibase Automations related work High priority Created by Linear-GitHub Sync labels Jun 19, 2023
@melohagan melohagan added bug Something isn't working env - production Bug found in production labels Jun 20, 2023
@andz-bb andz-bb added the firestorm Data/Infra/Revenue Team label Jun 20, 2023
@andz-bb andz-bb closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bb-automations Budibase Automations related work bug Something isn't working env - production Bug found in production firestorm Data/Infra/Revenue Team High priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants