Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-7239] Cannot filter by relationship on new SQL datasource #11089

Closed
1 task done
melohagan opened this issue Jun 30, 2023 · 2 comments
Closed
1 task done

[BUDI-7239] Cannot filter by relationship on new SQL datasource #11089

melohagan opened this issue Jun 30, 2023 · 2 comments
Labels
bb-filtering Filtering data bb-relationships Relating to table relationships bug Something isn't working env - production Bug found in production firestorm Data/Infra/Revenue Team linear

Comments

@melohagan
Copy link
Collaborator

melohagan commented Jun 30, 2023

Checklist

  • I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Self
    • Method: docker single image
    • Budibase Version: 2.6.1 (Introduced, fine on 2.5.9)

Describe the bug
If you create a new SQL datasource after updating to 2.6+ then you can no longer filter by a relationship field in a Table block.

To Reproduce
Steps to reproduce the behavior:

  1. Update to 2.6+
  2. Create a new MySQL datasource
  3. Within a data table, define a new One->Many relationship
  4. Go to Design and add a Table block to a screen for the 'One' table
  5. Define filters.
  6. See that there are no relationship fields to pick!

Expected behavior
As a user, I should be able to filter my SQL tables by relationship in the Design section.

Screenshots
Employees with one->many relationship to salaries:

Table block filter - where are the salaries fields?

From SyncLinear.com | BUDI-7239

@melohagan melohagan added bug Something isn't working bb-relationships Relating to table relationships env - production Bug found in production bb-filtering Filtering data labels Jun 30, 2023
@melohagan melohagan changed the title Cannot filter by relationship on new SQL datasource [BUDI-7239] Cannot filter by relationship on new SQL datasource Jun 30, 2023
@melohagan melohagan added linear sev1 - critical Severity Level 1 Bug - Critical path loss of functionality labels Jun 30, 2023
@aptkingston
Copy link
Member

Had a look into this. Good news is that it's fixed (and permanently fixed) by refreshing your page. This only happens immediately after defining a new relationship. Leaving your app or refreshing your page will fix this. The problem is just that after defining a relationship, we do not immediately update the table schema state, which is used by the filter setting.

I'll downgrade this as it's nowhere near as bad as it first seemed thankfully.

@aptkingston aptkingston added sev3 - substantial and removed sev1 - critical Severity Level 1 Bug - Critical path loss of functionality labels Jun 30, 2023
@melohagan
Copy link
Collaborator Author

Brilliant @aptkingston Thanks very much for taking a look - glad to hear it. Explains why it hadn't been flagged up to this point. Have a great weekend!

@melohagan melohagan added the firestorm Data/Infra/Revenue Team label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bb-filtering Filtering data bb-relationships Relating to table relationships bug Something isn't working env - production Bug found in production firestorm Data/Infra/Revenue Team linear
Projects
None yet
Development

No branches or pull requests

2 participants