[BUDI-7264] Number of filters set is different between Match Any and Match All

[melohagan]

8Checklist

• I have searched budibase discussions and github issues to check if my issue already exists

Hosting

• Self
  • Method: docker compose
  • Budibase Version: 2.8.2
  • App Version: 2.8.2

Describe the bug
When adding filters to a Budibase DB table in the Design section, I noticed that in the settings panel the number of "filters set" changed depending on whether Match any or Match all was selected.

Related issue: #11018

To Reproduce
Steps to reproduce the behavior:

1. Add filters to a table block for a Budibase DB (see gif)
2. Switch between Match all and Match any, and save
3. Notice that Match all has the correct number, whereas Match any has +1 filter count.

Expected behavior
The number of filters set should not change when the Match All/Any setting is changed.

Screenshots

Source image

_{From SyncLinear.com | BUDI-7264}

[aptkingston]

Just to speed you up on this, the reason is that we append a filter to indicated that we want "match any".

.concat(matchAny ? [{ operator: "allOr" }] : [])

So in the button where we're counting the filters, we just need to filter out that one before counting them. I'm sure you've probably found this out already, but thought that might help!

[melohagan]

Cheers @aptkingston

Yeah that's what I did, just filtered to make sure a field property existed when counting. Working on the related Match all/any bug here: #11018 before pushing up