Table/column deletion checks and disabling fetched external table deletion #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e user understands what they are doing, also disabling external table deletion.
Codecov Report
@@ Coverage Diff @@
## develop #3477 +/- ##
===========================================
- Coverage 68.89% 68.84% -0.06%
===========================================
Files 137 137
Lines 4356 4365 +9
Branches 633 636 +3
===========================================
+ Hits 3001 3005 +4
- Misses 961 963 +2
- Partials 394 397 +3
Continue to review full report at Codecov.
|
…sed, also adding a fix for threading to disable it in development as node-ts was causing memory leaks on low memory systems (doesn't apply to production built version).
aptkingston
approved these changes
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings an update to the UI to make sure the user is aware of the risks when deleting a table or a column, making sure that the user is aware of the risk attached with deleting them. For now I have also disabled the ability to delete tables which weren't created by Budibase in external SQL tables as this has quite a bit of risk attached to it as well. If we want to enable this again it is a very simple change, but this just makes sure that we are aware of which tables were created through Budibase and which ones were imported.
Screenshots
Table deletion:
Column deletion:
