Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ampersand() leads to incorrect redirect url #47

Closed
Defcon0 opened this issue Jun 24, 2020 · 0 comments
Closed

ampersand() leads to incorrect redirect url #47

Defcon0 opened this issue Jun 24, 2020 · 0 comments
Assignees
@BugBuster1701
Labels
bug
Milestone
1.1.2

Comments

@Defcon0
Copy link

Defcon0 commented Jun 24, 2020

Hello,

we're currently having a problem with the following line

contao-banner-bundle/src/Resources/contao/controllers/FrontendBanner.php

Line 188 in 6724d83

$banner_url = ampersand($objBanners->banner_url);

which transforms

https://example.org?utm_source=something&utm_medium=something&utm_campaign=something

to

https://example.org?utm_source=something&utm_medium=something&utm_campaign=something

And this way the campaign doesn't track.

Is it okay to remove the ampersand() call?

Bye Defcon0
@BugBuster1701 BugBuster1701 self-assigned this Jun 24, 2020
@BugBuster1701 BugBuster1701 added this to the 1.1.2 milestone Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BugBuster1701 BugBuster1701

Labels
bug
Projects
None yet
Milestone
1.1.2
Development

No branches or pull requests
2 participants
@BugBuster1701 @Defcon0