Fix users request paginate params

kzaitsev · Feb 18, 2015 · fcfb443 · fcfb443
1 parent dcbdf15
commit fcfb443
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/users.go b/users.go
@@ -2,6 +2,7 @@ package gogitlab
 
 import (
 	"encoding/json"
+	"strconv"
 )
 
 const (
@@ -28,9 +29,12 @@ type User struct {
 	ColorSchemeId int    `json:"color_scheme_id,color_scheme_id"`
 }
 
-func (g *Gitlab) Users() ([]*User, error) {
+func (g *Gitlab) Users(page int, per_page int) ([]*User, error) {
 
-	url := g.ResourceUrl(users_url, nil)
+	qry := map[string]string{
+		"page":     strconv.Itoa(page),
+		"per_page": strconv.Itoa(per_page)}
+	url := g.ResourceUrlQuery(users_url, nil, qry)
 
 	var users []*User
 

diff --git a/users_test.go b/users_test.go
@@ -7,7 +7,7 @@ import (
 
 func TestUsers(t *testing.T) {
 	ts, gitlab := Stub("stubs/users/index.json")
-	users, err := gitlab.Users()
+	users, err := gitlab.Users(0, 100)
 
 	assert.Equal(t, err, nil)
 	assert.Equal(t, len(users), 2)