Fix blueprints not being uploaded when shift-clicked in blueprint library #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was quite an annoying small bug. Was trying to put some blueprints in blueprint library, but they well wouldn't simply appear in the list. Came out the uploading and downloading player is only set when the slot is clicked.
tambry
changed the title
|
Merged, thanks for the fix! Indeed, slotClick isn't needed anymore. I removed it. |
|
darn it, just found that bug myself to and wanted to do a pr, glad it's already fixed then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was trying to put some blueprints in blueprint library, but they well wouldn't simply appear in the list.
Came out the uploading and downloading player is only set when the slot is clicked, but not when shift clicked.
Also since the onSlotChanged is triggered always, slotClick doesn't seem to be needed anymore?