Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sided batteries #1765

Merged
merged 1 commit into from May 10, 2014
Merged

Add support for sided batteries #1765

merged 1 commit into from May 10, 2014

Conversation

Prototik
Copy link
Member

Close #1763.
And btw fix some requirements by @undergroundminer3 in #1762

@SpaceToad
Copy link
Member

Arf - this side request isn't going to be easy to take into account. If I understand correctly, your code is associating sides with a given tile class. But that's likely to be too restrictive, as different instances of the same tile may have different activated sides depending on the orientation.

We need to step back a bit on this one. What are the options here? An additional annotation for the side - but then you stored data that may not have to be stored in the first place. An interface with methods to override, but then that introduces a mandatory hybrid API model. Back to the drawing board.

Do you mind submitting a separate PR specifically for #1762? That part is more straightforward.

@Prototik
Copy link
Member Author

@SpaceToad yep, you right.
I update this PR for ISidedBatteryProvider interface, which should be more flexible then hardcoding sides in the tiles.

@SpaceToad SpaceToad merged commit cb3b3d1 into BuildCraft:6.0.x May 10, 2014
@SpaceToad
Copy link
Member

Alright - so that gives a dual model, the simple model through the annotation, and the extended model through the interface. There's one capability that isn't available through the annotation, which is the side. That's good enough at this stage I believe.

@SpaceToad
Copy link
Member

BTW - there's no notion of "energy kind" on the battery providers. That should probably be provided too.

@Prototik
Copy link
Member Author

One moment, I'm provide necessary things.

@Prototik Prototik mentioned this pull request May 10, 2014
@Prototik Prototik deleted the sided-mjbattery branch June 3, 2014 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Something small that would improve buildcraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants